Conversation
This reduces indirect function calls and should make the loops slightly faster. This make `saveCommon()` 6.78 % faster.
This wasn't any faster. This reverts commit 17b17f0bb4170365cbae9b32a7cba2d8c1f354a0. - loading 10M nodes: - original: 1.5313329999989946 ms - prealloc: 1.5921659999949043 ms - unitintialized pool slabs: 1.6173750000016298 ms
No need to call it for every node separately. It's probably already optimizied out of the loop but let's make it explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.